Skip to content

[SDK] chore: Update coinbase/wallet-sdk #6204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2025
Merged

[SDK] chore: Update coinbase/wallet-sdk #6204

merged 1 commit into from
Feb 8, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 8, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on updating the @coinbase/wallet-sdk dependency from version 4.2.4 to 4.3.0 and revising the TypeScript definitions in the package.json of the thirdweb package, ensuring consistency and proper versioning.

Detailed summary

  • Updated @coinbase/wallet-sdk from 4.2.4 to 4.3.0.
  • Revised typesVersions in packages/thirdweb/package.json to consolidate TypeScript definitions.
  • Ensured all dependencies in pnpm-lock.yaml reflect the updated versions and maintain consistency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:16am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:16am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:16am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:16am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:16am

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2025

🦋 Changeset detected

Latest commit: bf8c89b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 8, 2025
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Feb 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title Update coinbase/wallet-sdk [SDK] chore: Update coinbase/wallet-sdk Feb 8, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review February 8, 2025 03:07
@joaquim-verges joaquim-verges requested review from a team as code owners February 8, 2025 03:07
@socket-security
Copy link

socket-security bot commented Feb 8, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@coinbase/[email protected] 🔁 npm/@coinbase/[email protected] None +3 1.89 MB cb-felix-z

View full report↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 4 s (+32.2% 🔺) 4.9 s
thirdweb (cjs) 121.82 KB (0%) 2.5 s (0%) 8.2 s (-19.04% 🔽) 10.7 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 456 ms (+12.05% 🔺) 568 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 103 ms (-45.06% 🔽) 113 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 688 ms (-52.61% 🔽) 1.1 s

@joaquim-verges joaquim-verges merged commit f1cd253 into main Feb 8, 2025
30 of 35 checks passed
@joaquim-verges joaquim-verges deleted the 02-08-update_coinbase_wallet-sdk branch February 8, 2025 03:31
@joaquim-verges joaquim-verges mentioned this pull request Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@joaquim-verges joaquim-verges

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @jnsdls